Coinsult

|

Smart Contract Audit

2022-07-08T12:47:02+02:00

Arcade Kingdoms

Binance Smart Chain

100% progress

0 pending

Audit

pending

Advanced manual smart contract audit not yet completed by Coinsult

KYC

pending

Coinsult does not know the identity of the smart contract owner

Coinsult

Request your audit at coinsult.net

Advanced Manual
Smart Contract Audit

July 8, 2022

Audit requested by

Arcade Kingdoms

0x52EC25E58a9e144ff002625BB2AA58Cc6DA24Cb2

Arcade Kingdoms / Security Audit

Global Overview

Manual Code Review

In this audit report we will highlight the following issues:

Vulnerability Level

Total

Pending

Acknowledged

Resolved

0

6

0

1

0

Centralization Risks

Coinsult checked the following privileges:

Contract Privilege

Description

Owner needs to enable trading?

Owner can mint?

Owner can blacklist?

Owner can set fees?

Owner can exclude from fees?

Can be honeypotted?

Owner can set Max TX amount?

More owner priviliges are listed later in the report.

Arcade Kingdoms / Security Audit

1. Audit Summary

1.1 Audit scope

1.2 Tokenomics

1.3 Source Code

2. Disclaimer

3. Global Overview

3.1 Informational issues

3.2 Low-risk issues

3.3 Medium-risk issues

3.4 High-risk issues

4. Vulnerabilities Findings

5. Contract Privileges

5.1 Maximum Fee Limit Check

5.2 Contract Pausability Check

5.3 Max Transaction Amount Check

5.4 Exclude From Fees Check

5.5 Ability to Mint Check

5.6 Ability to Blacklist Check

5.7 Owner Privileges Check

6. Notes

6.1 Notes by Coinsult

6.2 Notes by Arcade Kingdoms

7. Contract Snapshot

8. Website Review

9. Certificate of Proof

Arcade Kingdoms / Security Audit

Audit Summary

Project Name

Arcade Kingdoms

Website

https://arcadekingdoms.com/

Blockchain

Binance Smart Chain

Smart Contract Language

Solidity

Contract Address

0x52EC25E58a9e144ff002625BB2AA58Cc6DA24Cb2

Audit Method

Static Analysis, Manual Review

Date of Audit

8 July 2022

This audit report has been prepared by Coinsult’s experts at the request of the client. In this audit, the results of the static analysis and the manual code review will be presented. The purpose of the audit is to see if the functions work as intended, and to identify potential security issues within the smart contract.

The information in this report should be used to understand the risks associated with the smart contract. This report can be used as a guide for the development team on how the contract could possibly be improved by remediating the issues that were identified.

Arcade Kingdoms / Security Audit

Audit Scope

Coinsult was comissioned by Arcade Kingdoms to perform an audit based on the following code:

https://bscscan.com/address/0x52EC25E58a9e144ff002625BB2AA58Cc6DA24Cb2#code

Note that we only audited the code available to us on this URL at the time of the audit. If the URL is not from any block explorer (main net), it may be subject to change. Always check the contract address on this audit report and compare it to the token you are doing research for.

Audit Method

Coinsult’s manual smart contract audit is an extensive methodical examination and analysis of the smart contract’s code that is used to interact with the blockchain. This process is conducted to discover errors, issues and security vulnerabilities in the code in order to suggest improvements and ways to fix them.

Coinsult uses software that checks for common vulnerability issues within smart contracts. We use automated tools that scan the contract for security vulnerabilities such as integer-overflow, integer-underflow, out-of-gas-situations, unchecked transfers, etc.

Coinsult’s manual code review involves a human looking at source code, line by line, to find vulnerabilities. Manual code review helps to clarify the context of coding decisions. Automated tools are faster but they cannot take the developer’s intentions and general business logic into consideration.

Arcade Kingdoms / Security Audit

Risk Classification

Coinsult uses certain vulnerability levels, these indicate how bad a certain issue is. The higher the risk, the more strictly it is recommended to correct the error before using the contract.

Vulnerability Level

Description

Does not compromise the functionality of the contract in any way

Won't cause any problems, but can be adjusted for improvement

Will likely cause problems and it is recommended to adjust

Will definitely cause problems, this needs to be adjusted

Coinsult has four statuses that are used for each risk level. Below we explain them briefly.

Risk Status

Description

Total amount of issues within this category

Risks that have yet to be addressed by the team

The team is aware of the risks but does not resolve them

The team has resolved and remedied the risk

Arcade Kingdoms / Security Audit

SWC Attack Analysis

The Smart Contract Weakness Classification Registry (SWC Registry) is an implementation of the weakness classification scheme proposed in EIP-1470. It is loosely aligned to the terminologies and structure used in the Common Weakness Enumeration (CWE) while overlaying a wide range of weakness variants that are specific to smart contracts.

ID

Description

Status

Function Default Visibility

Passed

Integer Overflow and Underflow

Passed

Outdated Compiler Version

Passed

Floating Pragma

Passed

Unchecked Call Return Value

Passed

Unprotected Ether Withdrawal

Passed

Unprotected SELFDESTRUCT Instruction

Passed

Reentrancy

Passed

State Variable Default Visibility

Passed

Uninitialized Storage Pointer

Passed

Assert Violation

Passed

Use of Deprecated Solidity Functions

Passed

Delegatecall to Untrusted Callee

Passed

DoS with Failed Call

Passed

Transaction Order Dependence

Passed

Authorization through tx.origin

Passed

Arcade Kingdoms / Security Audit

Block values as a proxy for time

Passed

Signature Malleability

Passed

Incorrect Constructor Name

Passed

Shadowing State Variables

Passed

Weak Sources of Randomness from Chain Attributes

Passed

Missing Protection against Signature Replay Attacks

Passed

Lack of Proper Signature Verification

Passed

Requirement Violation

Passed

Write to Arbitrary Storage Location

Passed

Incorrect Inheritance Order

Passed

Insufficient Gas Griefing

Passed

Arbitrary Jump with Function Type Variable

Passed

DoS With Block Gas Limit

Passed

Typographical Error

Passed

Right-To-Left-Override control character (U+202E)

Passed

Presence of unused variables

Passed

Unexpected Ether balance

Passed

Hash Collisions With Multiple Variable Length Arguments

Passed

Message call with hardcoded gas amount

Passed

Code With No Effects

Passed

Unencrypted Private Data On-Chain

Passed

Arcade Kingdoms / Security Audit

Error Code

Description

CWE-841

Contract does not use a ReEntrancyGuard

One of the major dangers of calling external contracts is that they can take over the control flow. In the reentrancy attack (a.k.a. recursive call attack), a malicious contract calls back into the calling contract before the first invocation of the function is finished. This may cause the different invocations of the function to interact in undesirable ways.

				
					Reentrancy in ArcadeKingdoms._transfer(address,address,uint256) (#450-475):
State variables written after the call(s):
- _transferWithoutTax(sender,recipient,amount) (#463)
- _balances[sender] = _balances[sender].sub(amount,BEP20: transfer amount exceeds balance) (#516-519)
- _balances[recipient] = _balances[recipient].add(amount) (#520)
- _transferWithTax(sender,recipient,amount) (#467)
- _balances[sender] = _balances[sender].sub(amount,BEP20: transfer amount exceeds balance) (#495-498)
- _balances[recipient] = _balances[recipient].add(taxedAmount) (#499)
- _balances[_taxStoreAddr] = _balances[_taxStoreAddr].add(tTax) (#503)
- _transferWithoutTax(sender,recipient,amount) (#469)
- _balances[sender] = _balances[sender].sub(amount,BEP20: transfer amount exceeds balance) (#516-519)
- _balances[recipient] = _balances[recipient].add(amount) (#520)
- _transferWithoutTax(sender,recipient,amount) (#473)
- _balances[sender] = _balances[sender].sub(amount,BEP20: transfer amount exceeds balance) (#516-519)
- _balances[recipient] = _balances[recipient].add(amount) (#520)
- _transferWithTax(sender,recipient,amount) (#467)
- _totalSupply = _totalSupply.sub(tTax) (#505)

Recommendation

The best practices to avoid Reentrancy weaknesses are: Make sure all internal state changes are performed before the call is executed. This is known as the Checks-Effects-Interactions pattern, or use a reentrancy lock (ie. OpenZeppelin’s ReentrancyGuard.

Arcade Kingdoms / Security Audit

Error Code

Description

SLT: 078

Too many digits

Literals with many digits are difficult to read and review.

				
					        _totalSupply = 100000000 * 1e18;

Recommendation

Use: Ether suffix, Time suffix, or The scientific notation

Exploit scenario

				
					contract MyContract{
    uint 1_ether = 10000000000000000000; 
}

While 1_ether looks like 1 ether, it is 10 ether. As a result, it’s likely to be used incorrectly.

Arcade Kingdoms / Security Audit

Error Code

Description

SLT: 056

No zero address validation for some functions

Detect missing zero address validation.

				
					    function setTaxStoreAddr(address _addr) external onlyOwner {
        _taxStoreAddr = _addr;
    }

Recommendation

Check that the new address is not zero.

Exploit scenario

				
					contract C {

  modifier onlyAdmin {
    if (msg.sender != owner) throw;
    _;
  }

  function updateOwner(address newOwner) onlyAdmin external {
    owner = newOwner;
  }
}

Bob calls updateOwner without specifying the newOwner, soBob loses ownership of the contract.

Arcade Kingdoms / Security Audit

Error Code

Description

SLT: 054

Missing events arithmetic

Detect missing events for critical arithmetic parameters.

				
					    function updateBuyTax(uint256 _percentage) external onlyOwner {
        _BUY_TAX = _percentage;
    }

    function updateSellTax(uint256 _percentage) external onlyOwner {
        _SELL_TAX = _percentage;
    }

    function setTaxEnabled(bool _enabled) external onlyOwner {
        _taxEnabled = _enabled;
    }

    function setTaxStoreEnabled(bool _enabled) external onlyOwner {
        _taxStoreEnabled = _enabled;
    }

Recommendation

Emit an event for critical parameter changes.

Exploit scenario

				
					contract C {

  modifier onlyAdmin {
    if (msg.sender != owner) throw;
    _;
  }

  function updateOwner(address newOwner) onlyAdmin external {
    owner = newOwner;
  }
}

updateOwner() has no event, so it is difficult to track off-chain changes in the buy price.

Arcade Kingdoms / Security Audit

Error Code

Description

SLT: 068

Conformance to Solidity naming conventions

Allow _ at the beginning of the mixed_case match for private variables and unused parameters.

				
					Parameter ArcadeKingdoms.updateBuyTax(uint256)._percentage (#230) is not in mixedCase
Parameter ArcadeKingdoms.updateSellTax(uint256)._percentage (#234) is not in mixedCase
Parameter ArcadeKingdoms.setTaxEnabled(bool)._enabled (#238) is not in mixedCase
Parameter ArcadeKingdoms.setTaxStoreEnabled(bool)._enabled (#242) is not in mixedCase
Parameter ArcadeKingdoms.setTaxStoreAddr(address)._addr (#246) is not in mixedCase
Variable ArcadeKingdoms._BUY_TAX (#189) is not in mixedCase
Variable ArcadeKingdoms._SELL_TAX (#190) is not in mixedCase

Recommendation

Follow the Solidity naming convention.

Rule exceptions

Allow constant variable name/symbol/decimals to be lowercase (ERC20).
Allow _ at the beginning of the mixed_case match for private variables and unused parameters.

Arcade Kingdoms / Security Audit

Error Code

Description

SLT: 076

Costly operations inside a loop

Costly operations inside a loop might waste gas, so optimizations are justified.

				
					    function removeTaxedAddress(address account) external onlyOwner {
        require(_isTaxedAddress[account], "ACK: Account is already removed");
        for (uint256 i = 0; i &lt; _taxedAddress.length; i++) {
            if (_taxedAddress[i] == account) {
                _taxedAddress[i] = _taxedAddress[_taxedAddress.length - 1];
                _isTaxedAddress[account] = false;
                _taxedAddress.pop();
                break;
            }
        }
    }

Recommendation

Use a local variable to hold the loop computation result.

Arcade Kingdoms / Security Audit

Error Code

Description

CSM-01

Incorrect if-statement syntax – ✅ Acknowledged

				
					    function _beforeTokenTransfer(
        address from,
        address to,
        uint256 amount
    ) internal {
        if (from == address(0) || to == address(0)) return;
        if (!antisnipeDisable &amp;&amp; address(antisnipe) != address(0))
            antisnipe.assureCanTransfer(msg.sender, from, to, amount);
    }

Recommendation

✅ Acknowledged by the team:
Intentional use of no curly brackets. “it is acceptable”

Arcade Kingdoms / Security Audit

Maximum Fee Limit Check

Error Code

Description

CEN-01

Coinsult tests if the owner of the smart contract can set the transfer, buy or sell fee to 25% or more. It is bad practice to set the fees to 25% or more, because owners can prevent healthy trading or even stop trading when the fees are set too high.

Type of fee

Description

Max transfer fee

Max buy fee

Max sell fee

Arcade Kingdoms / Security Audit

Contract Honeypot Check

Error Code

Description

CEN-02

Coinsult tests if the owner of the smart contract has the ability to pause the contract. If this is the case, users can no longer interact with the smart contract; users can no longer trade the token.

Privilege Check

Description

Can owner pause the contract?

Arcade Kingdoms / Security Audit

Max Transaction Amount Check

Error Code

Description

CEN-03

Coinsult tests if the owner of the smart contract can set the maximum amount of a transaction. If the transaction exceeds this limit, the transaction will revert. Owners could prevent normal transactions to take place if they abuse this function.

Privilege Check

Description

Can owner set max tx amount?

Arcade Kingdoms / Security Audit

Exclude From Fees Check

Error Code

Description

CEN-04

Coinsult tests if the owner of the smart contract can exclude addresses from paying tax fees. If the owner of the smart contract can exclude from fees, they could set high tax fees and exclude themselves from fees and benefit from 0% trading fees. However, some smart contracts require this function to exclude routers, dex, cex or other contracts / wallets from fees.

Privilege Check

Description

Can owner exclude from fees?

Arcade Kingdoms / Security Audit

Ability To Mint Check

Error Code

Description

CEN-05

Coinsult tests if the owner of the smart contract can mint new tokens. If the contract contains a mint function, we refer to the token’s total supply as non-fixed, allowing the token owner to “mint” more tokens whenever they want.

A mint function in the smart contract allows minting tokens at a later stage. A method to disable minting can also be added to stop the minting process irreversibly.

Minting tokens is done by sending a transaction that creates new tokens inside of the token smart contract. With the help of the smart contract function, an unlimited number of tokens can be created without spending additional energy or money.

Privilege Check

Description

Can owner mint?

Arcade Kingdoms / Security Audit

Enable Trading

Error Code

Description

CEN-06

Coinsult tests if the owner of the smart contract needs to manually enable trading before everyone can buy & sell. If the owner needs to manually enable trading, this poses a high centralization risk.

If the owner needs to manually enable trading, make sure to check if the project has a SAFU badge or a trusted KYC badge. Always DYOR when investing in a project that needs to manually enable trading.

Privilege Check

Description

Owner needs to enable trading?

Arcade Kingdoms / Security Audit

Ability To Blacklist Check

Error Code

Description

CEN-07

Coinsult tests if the owner of the smart contract can blacklist accounts from interacting with the smart contract. Blacklisting methods allow the contract owner to enter wallet addresses which are not allowed to interact with the smart contract.

This method can be abused by token owners to prevent certain / all holders from trading the token. However, blacklists might be good for tokens that want to rule out certain addresses from interacting with a smart contract.

Privilege Check

Description

Can owner blacklist?

Arcade Kingdoms / Security Audit

Other Owner Privileges Check

Error Code

Description

CEN-100

Coinsult lists all important contract methods which the owner can interact with.

✅ No other important owner privileges to mention.

Arcade Kingdoms / Security Audit

Notes

Notes by Arcade Kingdoms

No notes provided by the team.

Notes by Coinsult

No notes provided by Coinsult

Arcade Kingdoms / Security Audit

Contract Snapshot

This is how the constructor of the contract looked at the time of auditing the smart contract.

				
					contract ArcadeKingdoms is Context, IBEP20, Ownable {
    using SafeMath for uint256;

    mapping(address =&gt; uint256) private _balances;

    mapping(address =&gt; mapping(address =&gt; uint256)) private _allowances;

    /**
     * @dev Enable or Disable tax system
     */
    bool private _taxEnabled;
    /**
     * @dev To either store or burn tax
     */
    bool private _taxStoreEnabled;

    /**
     * @dev tax percentage to be deducted from taxed transaction
     */
    uint256 private _BUY_TAX = 1; // %
    uint256 private _SELL_TAX = 1; // %

    /**
     * @dev address to store tax collected
     */
    address private _taxStoreAddr;

    IAntisnipe public antisnipe = IAntisnipe(address(0));
    bool public antisnipeDisable;

    /**
     * @dev Store addresses included in tax collection
     * @dev Sending to addresses included in tax collection will remove tax using the percentage in _BUY_TAX and _SELL_TAX
     */
    mapping(address =&gt; bool) private _isTaxedAddress;
    address[] private _taxedAddress;

    /**
     * @dev Store addresses excluded from tax collection
     * @dev these addresses will not be taxed even if tax is enabled and its condition met
     */

Arcade Kingdoms / Security Audit

Website Review

Coinsult checks the website completely manually and looks for visual, technical and textual errors. We also look at the security, speed and accessibility of the website. In short, a complete check to see if the website meets the current standard of the web development industry.

Type of check

Description

Mobile friendly?

Contains jQuery errors?

Is SSL secured?

Contains spelling errors?

Arcade Kingdoms / Security Audit

Certificate of Proof

Arcade Kingdoms

Audited by Coinsult.net

Date: 8 July 2022

Arcade Kingdoms / Security Audit

Disclaimer

Coinsult is not responsible if a project turns out to be a scam, rug-pull or honeypot. We only provide a detailed analysis for your own research.

Coinsult is not responsible for any financial losses. Nothing in this contract audit is financial advice, please do your own research.

The information provided in this audit is for informational purposes only and should not be considered investment advice. Coinsult does not endorse, recommend, support or suggest to invest in any project.

Coinsult can not be held responsible for when a project turns out to be a rug-pull, honeypot or scam.

Coinsult

|

Smart Contract Audit

2022-07-08T12:47:02+02:00

Arcade Kingdoms

Binance Smart Chain

100% progress

0 pending

0 pending

0 pending

Audit

pending

Advanced manual smart contract audit not yet completed by Coinsult

KYC

pending

Coinsult does not know the identity of the smart contract owner

Coinsult

Request your audit at coinsult.net

Advanced Manual Smart Contract Audit

July 8, 2022

Audit requested by

Arcade Kingdoms

0x52EC25E58a9e144ff002625BB2AA58Cc6DA24Cb2

Arcade Kingdoms / Security Audit

Global Overview

Manual Code Review

Vulnerability Level

Total

Pending

Acknowledged

Resolved

0

0

0

0

6

0

0

0

1

0

0

0

0

0

0

0

Centralization Risks

Contract Privilege

Description

Owner needs to enable trading?

Owner can mint?

Owner can blacklist?

Owner can set fees?

Owner can exclude from fees?

Can be honeypotted?

Owner can set Max TX amount?

Arcade Kingdoms / Security Audit

Table of Contents

1. Audit Summary

1.1 Audit scope

1.2 Tokenomics

1.3 Source Code

2. Disclaimer

3. Global Overview

3.1 Informational issues

3.2 Low-risk issues

3.3 Medium-risk issues

3.4 High-risk issues

4. Vulnerabilities Findings

5. Contract Privileges

5.1 Maximum Fee Limit Check

5.2 Contract Pausability Check

5.3 Max Transaction Amount Check

5.4 Exclude From Fees Check

5.5 Ability to Mint Check

5.6 Ability to Blacklist Check

5.7 Owner Privileges Check

6. Notes

6.1 Notes by Coinsult

Advanced Manual
Smart Contract Audit