In this audit report we will highlight the following issues:
Coinsult checked the following privileges:
More owner priviliges are listed later in the report.
This audit report has been prepared by Coinsult’s experts at the request of the client. In this audit, the results of the static analysis and the manual code review will be presented. The purpose of the audit is to see if the functions work as intended, and to identify potential security issues within the smart contract.
The information in this report should be used to understand the risks associated with the smart contract. This report can be used as a guide for the development team on how the contract could possibly be improved by remediating the issues that were identified.
Note that we only audited the code available to us on this URL at the time of the audit. If the URL is not from any block explorer (main net), it may be subject to change. Always check the contract address on this audit report and compare it to the token you are doing research for.
✅ Ownership Renounced Jun-08-2022 07:59:37 AM +UTC
https://bscscan.com/tx/0x1b89a45c448dd64477684f829608422ac9a870e3111c59e58a20b36a2e3729fe
Coinsult’s manual smart contract audit is an extensive methodical examination and analysis of the smart contract’s code that is used to interact with the blockchain. This process is conducted to discover errors, issues and security vulnerabilities in the code in order to suggest improvements and ways to fix them.
Coinsult uses software that checks for common vulnerability issues within smart contracts. We use automated tools that scan the contract for security vulnerabilities such as integer-overflow, integer-underflow, out-of-gas-situations, unchecked transfers, etc.
Coinsult’s manual code review involves a human looking at source code, line by line, to find vulnerabilities. Manual code review helps to clarify the context of coding decisions. Automated tools are faster but they cannot take the developer’s intentions and general business logic into consideration.
Coinsult uses certain vulnerability levels, these indicate how bad a certain issue is. The higher the risk, the more strictly it is recommended to correct the error before using the contract.
Coinsult has four statuses that are used for each risk level. Below we explain them briefly.
The Smart Contract Weakness Classification Registry (SWC Registry) is an implementation of the weakness classification scheme proposed in EIP-1470. It is loosely aligned to the terminologies and structure used in the Common Weakness Enumeration (CWE) while overlaying a wide range of weakness variants that are specific to smart contracts.
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Passed
Avoid relying on block.timestamp
block.timestamp can be manipulated by miners.
function _transfer(
address sender,
address receiver,
uint256 amount
) internal virtual override {
require(
receiver != address(this),
string("No transfers to contract allowed.")
);
require(!isBlacklist[sender], "User blacklisted");
uint256 taxAmount = 0;
if (liquidityPool[sender] == true) {
//It's an LP Pair and it's a buy
taxAmount = (amount * buyTax) / MAX_PERCENT;
} else if (liquidityPool[receiver] == true) {
//It's an LP Pair and it's a sell
taxAmount = (amount * sellTax) / MAX_PERCENT;
uint256 transactionTime = block.timestamp;
require(
lastTrade[sender] 0) {
super._transfer(sender, marketingPool, taxAmount);
}
super._transfer(sender, receiver, amount - taxAmount);
}
}
Recommendation
Do not use block.timestamp
, now
or blockhash
as a source of randomness
Exploit scenario
contract Game {
uint reward_determining_number;
function guessing() external{
reward_determining_number = uint256(block.blockhash(10000)) % 10;
}
}
Eve is a miner. Eve calls guessing
and re-orders the block containing the transaction. As a result, Eve wins the game.
No zero address validation for some functions
Detect missing zero address validation.
function setMarketingPool(address _marketingPool) external onlyOwner {
marketingPool = _marketingPool;
emit ChangeMarketingPool(_marketingPool);
}
Recommendation
Check that the new address is not zero.
Exploit scenario
contract C {
modifier onlyAdmin {
if (msg.sender != owner) throw;
_;
}
function updateOwner(address newOwner) onlyAdmin external {
owner = newOwner;
}
}
Bob calls updateOwner
without specifying the newOwner
, soBob loses ownership of the contract.
Conformance to Solidity naming conventions
Allow _ at the beginning of the mixed_case match for private variables and unused parameters.
function setBlacklist(address _wallet, bool _status) external onlyOwner {
isBlacklist[_wallet] = _status;
emit ChangeBlacklist(_wallet, _status);
}
Recommendation
Follow the Solidity naming convention.
Rule exceptions
ERC20
)._
at the beginning of the mixed_case
match for private variables and unused parameters.Code With No Effects
Detect the usage of redundant statements that have no effect.
function _msgData() internal view returns (bytes memory) {
this;
return msg.data;
}
Recommendation
Remove redundant statements if they congest code but offer no value.
Exploit scenario
contract RedundantStatementsContract {
constructor() public {
uint; // Elementary Type Name
bool; // Elementary Type Name
RedundantStatementsContract; // Identifier
}
function test() public returns (uint) {
uint; // Elementary Type Name
assert; // Identifier
test; // Identifier
return 777;
}
}
Each commented line references types/identifiers, but performs no action with them, so no code will be generated for such statements and they can be removed.
require(
receiver != address(this),
string("No transfers to contract allowed.")
);
Recommendation
Coinsult tests if the owner of the smart contract can set the transfer, buy or sell fee to 25% or more. It is bad practice to set the fees to 25% or more, because owners can prevent healthy trading or even stop trading when the fees are set too high.
Coinsult tests if the owner of the smart contract has the ability to pause the contract. If this is the case, users can no longer interact with the smart contract; users can no longer trade the token.
Coinsult tests if the owner of the smart contract can set the maximum amount of a transaction. If the transaction exceeds this limit, the transaction will revert. Owners could prevent normal transactions to take place if they abuse this function.
Coinsult tests if the owner of the smart contract can exclude addresses from paying tax fees. If the owner of the smart contract can exclude from fees, they could set high tax fees and exclude themselves from fees and benefit from 0% trading fees. However, some smart contracts require this function to exclude routers, dex, cex or other contracts / wallets from fees.
Coinsult tests if the owner of the smart contract can mint new tokens. If the contract contains a mint function, we refer to the token’s total supply as non-fixed, allowing the token owner to “mint” more tokens whenever they want.
A mint function in the smart contract allows minting tokens at a later stage. A method to disable minting can also be added to stop the minting process irreversibly.
Minting tokens is done by sending a transaction that creates new tokens inside of the token smart contract. With the help of the smart contract function, an unlimited number of tokens can be created without spending additional energy or money.
Coinsult tests if the owner of the smart contract needs to manually enable trading before everyone can buy & sell. If the owner needs to manually enable trading, this poses a high centralization risk.
If the owner needs to manually enable trading, make sure to check if the project has a SAFU badge or a trusted KYC badge. Always DYOR when investing in a project that needs to manually enable trading.
Coinsult tests if the owner of the smart contract can blacklist accounts from interacting with the smart contract. Blacklisting methods allow the contract owner to enter wallet addresses which are not allowed to interact with the smart contract.
This method can be abused by token owners to prevent certain / all holders from trading the token. However, blacklists might be good for tokens that want to rule out certain addresses from interacting with a smart contract.
Coinsult lists all important contract methods which the owner can interact with.
⚠ Owner can set trade cooldown
✅ Ownership Renounced Jun-08-2022 07:59:37 AM +UTC
https://bscscan.com/tx/0x1b89a45c448dd64477684f829608422ac9a870e3111c59e58a20b36a2e3729fe
✅ Ownership Renounced Jun-08-2022 07:59:37 AM +UTC
https://bscscan.com/tx/0x1b89a45c448dd64477684f829608422ac9a870e3111c59e58a20b36a2e3729fe
This is how the constructor of the contract looked at the time of auditing the smart contract.
contract SuperToken is BEP20Detailed, BEP20 {
uint256 constant private MAX_PERCENT = 100;
mapping(address => bool) private isBlacklist;
mapping(address => bool) private liquidityPool;
mapping(address => bool) private whitelistTax;
mapping(address => uint256) private lastTrade;
uint8 private buyTax;
uint8 private sellTax;
uint8 private tradeCooldown;
uint8 private transferTax;
//uint256 private taxAmount;
Coinsult checks the website completely manually and looks for visual, technical and textual errors. We also look at the security, speed and accessibility of the website. In short, a complete check to see if the website meets the current standard of the web development industry.
This audit report has been prepared by Coinsult’s experts at the request of the client. In this audit, the results of the static analysis and the manual code review will be presented. The purpose of the audit is to see if the functions work as intended, and to identify potential security issues within the smart contract.
The information in this report should be used to understand the risks associated with the smart contract. This report can be used as a guide for the development team on how the contract could possibly be improved by remediating the issues that were identified.
Coinsult is not responsible if a project turns out to be a scam, rug-pull or honeypot. We only provide a detailed analysis for your own research.
Coinsult is not responsible for any financial losses. Nothing in this contract audit is financial advice, please do your own research.
The information provided in this audit is for informational purposes only and should not be considered investment advice. Coinsult does not endorse, recommend, support or suggest to invest in any project.
Coinsult can not be held responsible for when a project turns out to be a rug-pull, honeypot or scam.