Coinsult

Request your audit at coinsult.net

Advanced Manual
Smart Contract Audit

June 25, 2022

Audit requested by

Get Schiffy Token

0x4aa6027De5acf37eF2221Af51c5a8930E44e52F6

Get Schiffy Token / Security Audit

Table of Contents

1. Audit Summary

1.1 Audit scope

1.2 Tokenomics

1.3 Source Code

2. Disclaimer

3. Global Overview

3.1 Informational issues

3.2 Low-risk issues

3.3 Medium-risk issues

3.4 High-risk issues

4. Vulnerabilities Findings

5. Contract Privileges

5.1 Maximum Fee Limit Check

5.2 Contract Pausability Check

5.3 Max Transaction Amount Check

5.4 Exclude From Fees Check

5.5 Ability to Mint Check

5.6 Ability to Blacklist Check

5.7 Owner Privileges Check

6. Notes

6.1 Notes by Coinsult

6.2 Notes by Get Schiffy Token

7. Contract Snapshot

8. Website Review

9. Certificate of Proof

Get Schiffy Token / Security Audit

Audit Summary

Audit Scope

Project Name

Get Schiffy Token

Blockchain

Binance Smart Chain

Smart Contract Language

Solidity

Contract Address

0x4aa6027De5acf37eF2221Af51c5a8930E44e52F6

Audit Method

Static Analysis, Manual Review

Date of Audit

25 June 2022

This audit report has been prepared by Coinsult’s experts at the request of the client. In this audit, the results of the static analysis and the manual code review will be presented. The purpose of the audit is to see if the functions work as intended, and to identify potential security issues within the smart contract.

The information in this report should be used to understand the risks associated with the smart contract. This report can be used as a guide for the development team on how the contract could possibly be improved by remediating the issues that were identified.

Get Schiffy Token / Security Audit

Tokenomics

Rank Address Quantity (Token) Percentage
1  0x407993575c91ce7643a4d4ccacc9a98c36ee1bbe 746,205,963,000 74.6206%
2  0xc00b613698ba19f82a6e4f47bc2ddae2dcfe4a7b 96,152,856,420.563205638160876875 9.6153%
3  0xd25a3afcec7ff51fa194e09788277918df263ef4 46,957,530,000 4.6958%
4 0xfe64d9b21bc114e6f1ccaef73ba519b327732713 8,364,030,112.2928361424099 0.8364%
5 0x12d0704441bc04c6b661685f70c51993716d9dbc 7,793,611,164.55380353149965 0.7794%

 

Source Code

Coinsult was comissioned by Get Schiffy Token to perform an audit based on the following code:
https://bscscan.com/address/0x4aa6027De5acf37eF2221Af51c5a8930E44e52F6#code

Get Schiffy Token / Security Audit

Disclaimer

This audit report has been prepared by Coinsult’s experts at the request of the client. In this audit, the results of the static analysis and the manual code review will be presented. The purpose of the audit is to see if the functions work as intended, and to identify potential security issues within the smart contract.

The information in this report should be used to understand the risks associated with the smart contract. This report can be used as a guide for the development team on how the contract could possibly be improved by remediating the issues that were identified.

Coinsult is not responsible if a project turns out to be a scam, rug-pull or honeypot. We only provide a detailed analysis for your own research.

Coinsult is not responsible for any financial losses. Nothing in this contract audit is financial advice, please do your own research.

The information provided in this audit is for informational purposes only and should not be considered investment advice. Coinsult does not endorse, recommend, support or suggest to invest in any project. 

Coinsult can not be held responsible for when a project turns out to be a rug-pull, honeypot or scam.

Get Schiffy Token / Security Audit

Global Overview

Manual Code Review

In this audit report we will highlight the following issues:

Vulnerability Level

Total

Pending

Acknowledged

Resolved

0

0

0

0

6

0

0

0

3

0

0

0

0

0

0

0

Privilege Overview

Coinsult checked the following privileges:

Contract Privilege

Description

Owner can mint?

Owner can blacklist?

Owner can set fees > 25%?

Owner can exclude from fees?

Owner can pause trading?

Owner can set Max TX amount?

More owner priviliges are listed later in the report.

Get Schiffy Token / Security Audit

Contract contains Reentrancy vulnerabilities

Additional information: This combination increases risk of malicious intent. While it may be justified by some complex mechanics (e.g. rebase, reflections, buyback). 

More information: Slither

				
					External calls:
- uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#683-684)
State variables written after the call(s):
- setExcludes() (#687)
- _isExcludedFromFee[owner()] = true (#693)
- _isExcludedFromFee[address(this)] = true (#694)
- _isExcludedFromFee[_playToEarnWallet] = true (#695)
- setExcludes() (#687)
- _isExcludedFromMaxTx[owner()] = true (#697)
- _isExcludedFromMaxTx[address(this)] = true (#698)
- _isExcludedFromMaxTx[_playToEarnWallet] = true (#699)
- uniswapV2Router = _uniswapV2Router (#685)
				
			

Recommendation

Apply the check-effects-interactions pattern.

Exploit scenario

				
					    function withdrawBalance(){
        // send userBalance[msg.sender] Ether to msg.sender
        // if mgs.sender is a contract, it will call its fallback function
        if( ! (msg.sender.call.value(userBalance[msg.sender])() ) ){
            throw;
        }
        userBalance[msg.sender] = 0;
    }
				
			
Bob uses the re-entrancy bug to call withdrawBalance two times, and withdraw more than its initial deposit to the contract.

Get Schiffy Token / Security Audit

Avoid relying on block.timestamp

block.timestamp can be manipulated by miners.

				
					    //Locks the contract for owner for the amount of time provided
    function lock(uint256 time) public virtual onlyOwner {
        _previousOwner = _owner;
        _owner = address(0);
        _lockTime = block.timestamp + time;
        emit OwnershipTransferred(_owner, address(0));
    }
    
    //Unlocks the contract for owner when _lockTime is exceeds
    function unlock() public virtual {
        require(_previousOwner == msg.sender, "You don't have permission to unlock");
        require(block.timestamp > _lockTime , "Contract is locked until 7 days");
        emit OwnershipTransferred(_owner, _previousOwner);
        _owner = _previousOwner;
    }
				
			

Recommendation

Do not use block.timestampnow or blockhash as a source of randomness

Exploit scenario

				
					contract Game {

    uint reward_determining_number;

    function guessing() external{
      reward_determining_number = uint256(block.blockhash(10000)) % 10;
    }
}
				
			

Eve is a miner. Eve calls guessing and re-orders the block containing the transaction. As a result, Eve wins the game.

Get Schiffy Token / Security Audit

Too many digits

Literals with many digits are difficult to read and review.

				
					    uint256 public swapThreshold = (_tTotal * 10) / 100000; // 0.01% of supply
				
			

Recommendation

Exploit scenario

				
					contract MyContract{
    uint 1_ether = 10000000000000000000; 
}
				
			

While 1_ether looks like 1 ether, it is 10 ether. As a result, it’s likely to be used incorrectly.

Get Schiffy Token / Security Audit

No zero address validation for some functions

Detect missing zero address validation.

				
					    event UpdateFeeReceiver(address newwallet);
    function updateAdminFeeReceirver(address newwallet) external onlyOwner {
        adminFeeReceiver = newwallet;
        emit UpdateFeeReceiver(newwallet);
    }
				
			

Recommendation

Check that the new address is not zero.

Exploit scenario

				
					contract C {

  modifier onlyAdmin {
    if (msg.sender != owner) throw;
    _;
  }

  function updateOwner(address newOwner) onlyAdmin external {
    owner = newOwner;
  }
}
				
			

Bob calls updateOwner without specifying the newOwner, soBob loses ownership of the contract.

Get Schiffy Token / Security Audit

Missing events arithmetic

Detect missing events for critical arithmetic parameters.

				
					    function excludeFromFee(address account) public onlyOwner {
        _isExcludedFromFee[account] = true;
    }
    
    function includeInFee(address account) public onlyOwner {
        _isExcludedFromFee[account] = false;
    }
    
    function setTaxFeePercent(uint256 taxFee) external onlyOwner() {
        _taxFee = taxFee;
    }
    
    function setPlayToEarnFeePercent(uint256 liquidityFee) external onlyOwner() {
        _playToEarn = liquidityFee;
    }
   
    function setMaxTxPercent(uint256 maxTxPercent) external onlyOwner() {
        _maxTxAmount = _tTotal.mul(maxTxPercent).div(10**2);
    }
				
			

Recommendation

Emit an event for critical parameter changes.

Exploit scenario

				
					contract C {

  modifier onlyAdmin {
    if (msg.sender != owner) throw;
    _;
  }

  function updateOwner(address newOwner) onlyAdmin external {
    owner = newOwner;
  }
}
				
			

updateOwner() has no event, so it is difficult to track off-chain changes in the buy price.

Get Schiffy Token / Security Audit

Conformance to Solidity naming conventions

Allow _ at the beginning of the mixed_case match for private variables and unused parameters.

				
					Function IUniswapV2Pair.DOMAIN_SEPARATOR() (#469) is not in mixedCase
Function IUniswapV2Pair.PERMIT_TYPEHASH() (#470) is not in mixedCase
Function IUniswapV2Pair.MINIMUM_LIQUIDITY() (#487) is not in mixedCase
Function IUniswapV2Router01.WETH() (#507) is not in mixedCase
Variable GetSchiffyGold.SWAPTOKEN (#667) is not in mixedCase
				
			

Recommendation

Follow the Solidity naming convention.

Rule exceptions

  • Allow constant variable name/symbol/decimals to be lowercase (ERC20).
  • Allow _ at the beginning of the mixed_case match for private variables and unused parameters.

Get Schiffy Token / Security Audit

Costly operations inside a loop

Costly operations inside a loop might waste gas, so optimizations are justified. 

				
					    function includeInReward(address account) external onlyOwner() {
        require(_isExcluded[account], "Account is already excluded");
        for (uint256 i = 0; i < _excluded.length; i++) {
            if (_excluded[i] == account) {
                _excluded[i] = _excluded[_excluded.length - 1];
                _tOwned[account] = 0;
                _isExcluded[account] = false;
                _excluded.pop();
                break;
            }
        }
    }
				
			

Recommendation

Use a local variable to hold the loop computation result.

Exploit scenario

				
					contract CostlyOperationsInLoop{

    function bad() external{
        for (uint i=0; i < loop_count; i++){
            state_variable++;
        }
    }

    function good() external{
      uint local_variable = state_variable;
      for (uint i=0; i < loop_count; i++){
        local_variable++;
      }
      state_variable = local_variable;
    }
}
				
			

Incrementing state_variable in a loop incurs a lot of gas because of expensive SSTOREs, which might lead to an out-of-gas.

No check on lock time
				
					    //Locks the contract for owner for the amount of time provided
    function lock(uint256 time) public virtual onlyOwner {
        _previousOwner = _owner;
        _owner = address(0);
        _lockTime = block.timestamp + time;
        emit OwnershipTransferred(_owner, address(0));
    }
				
			

Recommendation

Since you rennounce the ownership of the contract for an X amount of time, you should check this value (x) to be sure you won’t unintentionally lock it for too long / infinity and you won’t be able to get ownership of the contract back.

✅ Acknowledged by Get Schiffy
Wrong event emitted
				
					event ExcludeFromReward(address indexed account);
    function excludeFromReward(address account) external onlyOwner() {
        require(!_isExcluded[account], "Account is already excluded");
        if(_rOwned[account] &gt; 0) {
            _tOwned[account] = tokenFromReflection(_rOwned[account]);
        }
        _isExcluded[account] = true;
        _excluded.push(account);
        emit ExcludeFromMaxTx(account);
    }

				
			

Recommendation

When you exclude from rewards, you emitted an excluded from max transaction event. Which is not correct.

✅ Comment by Get Schiffy:
This poses no risk to token holders at all.
Unchecked transfer, but event emitted
				
						    event ClaimedBUSD(address indexed to, uint256 amount);
    function claimBusd() external onlyOwner {
        emit ClaimedBUSD(_msgSender(), SWAPTOKEN.balanceOf(address(this)));
        SWAPTOKEN.transfer(_msgSender(), SWAPTOKEN.balanceOf(address(this)));
    }
				
			

Recommendation

First perform the transfer, then check successful transfer, then emit event.

✅ Comment by Get Schiffy
This poses no risk to token holders at all.

Get Schiffy Token / Security Audit

Contract Privileges

Maximum Fee Limit Check

Coinsult tests if the owner of the smart contract can set the transfer, buy or sell fee to 25% or more. It is bad practice to set the fees to 25% or more, because owners can prevent healthy trading or even stop trading when the fees are set too high. 

Type of fee

Description

Transfer fee

Buy fee

Sell fee

Type of fee

Description

Max transfer fee

Max buy fee

Max sell fee

Get Schiffy Token / Security Audit

Contract Pausability Check

Coinsult tests if the owner of the smart contract has the ability to pause the contract. If this is the case, users can no longer interact with the smart contract; users can no longer trade the token.

Privilege Check

Description

Can owner pause the contract?

Get Schiffy Token / Security Audit

Max Transaction Amount Check

Coinsult tests if the owner of the smart contract can set the maximum amount of a transaction. If the transaction exceeds this limit, the transaction will revert. Owners could prevent normal transactions to take place if they abuse this function.

Privilege Check

Description

Can owner set max tx amount?

Get Schiffy Token / Security Audit

Exclude From Fees Check

Coinsult tests if the owner of the smart contract can exclude addresses from paying tax fees. If the owner of the smart contract can exclude from fees, they could set high tax fees and exclude themselves from fees and benefit from 0% trading fees. However, some smart contracts require this function to exclude routers, dex, cex or other contracts / wallets from fees.

Privilege Check

Description

Can owner exclude from fees?

Get Schiffy Token / Security Audit

Ability To Mint Check

Coinsult tests if the owner of the smart contract can mint new tokens. If the contract contains a mint function, we refer to the token’s total supply as non-fixed, allowing the token owner to “mint” more tokens whenever they want.

A mint function in the smart contract allows minting tokens at a later stage. A method to disable minting can also be added to stop the minting process irreversibly.

Minting tokens is done by sending a transaction that creates new tokens inside of the token smart contract. With the help of the smart contract function, an unlimited number of tokens can be created without spending additional energy or money.

Privilege Check

Description

Can owner mint?

Get Schiffy Token / Security Audit

Ability To Blacklist Check

Coinsult tests if the owner of the smart contract can blacklist accounts from interacting with the smart contract. Blacklisting methods allow the contract owner to enter wallet addresses which are not allowed to interact with the smart contract. 

This method can be abused by token owners to prevent certain / all holders from trading the token. However, blacklists might be good for tokens that want to rule out certain addresses from interacting with a smart contract.

Privilege Check

Description

Can owner blacklist?

Get Schiffy Token / Security Audit

Other Owner Privileges Check

Coinsult lists all important contract methods which the owner can interact with.

✅ No other important owner privileges to mention.

Get Schiffy Token / Security Audit

Notes

Notes by Get Schiffy Token

No notes provided by the team.

Notes by Coinsult

✅ No notes provided by Coinsult

Get Schiffy Token / Security Audit

Contract Snapshot

This is how the constructor of the contract looked at the time of auditing the smart contract.

				
					contract GetSchiffyGold is Context, IGOLD, Ownable {
    using SafeMath for uint256;
    using Address for address;

    mapping (address =&gt; uint256) private _rOwned;
    mapping (address =&gt; uint256) private _tOwned;
    mapping (address =&gt; mapping (address =&gt; uint256)) private _allowances;
    mapping (address =&gt; bool) private _isExcludedFromFee;
    mapping (address =&gt; bool) private _isExcluded;
    mapping (address =&gt; bool) private _isExcludedFromMaxTx;

    address[] private _excluded;
    uint256 private constant MAX = ~uint256(0);
    uint256 private _tTotal = 1 * 10**12 * 10**18;
    uint256 private _rTotal = (MAX - (MAX % _tTotal));
    string private _name;
    string private _symbol;
    uint8 private _decimals = 18;
    
    uint256 private _playToEarn = 50;
    uint256 private _previousPlayToEarn = _playToEarn;
    uint256 private _taxFee = 25;
    uint256 private _previousTaxFee = _taxFee;
    uint256 private _tFeeTotal;

    IUniswapV2Router02 public uniswapV2Router;
    address public uniswapV2Pair;
    IGOLD public SWAPTOKEN = IGOLD(0xe9e7CEA3DedcA5984780Bafc599bD69ADd087D56);
    uint256 public _maxTxAmount;
    uint256 public swapThreshold = (_tTotal * 10) / 100000; // 0.01% of supply
    address public adminFeeReceiver;
        
    constructor() {
        _name = "Get Schiffy Gold";
        _symbol = "GOLD";
        _maxTxAmount = _tTotal.mul(5).div(10**3);
        _rOwned[_msgSender()] = _rTotal;
        IUniswapV2Router02 _uniswapV2Router = IUniswapV2Router02(0x10ED43C718714eb63d5aA57B78B54704E256024E);
        uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory())
            .createPair(address(this), _uniswapV2Router.WETH());
        uniswapV2Router = _uniswapV2Router;        
        setExcludes();
        adminFeeReceiver = _msgSender();
        emit Transfer(address(0), _msgSender(), _tTotal);
    }
				
			

Get Schiffy Token / Security Audit

Website Review

Coinsult checks the website completely manually and looks for visual, technical and textual errors. We also look at the security, speed and accessibility of the website. In short, a complete check to see if the website meets the current standard of the web development industry. 

Type of check

Description

Mobile friendly?

Contains jQuery errors?

Is SSL secured?

Contains spelling errors?

Get Schiffy Token / Security Audit

Certificate of Proof

Get Schiffy Token

Audited by Coinsult.net

Date: 25 June 2022

Coinsult

coinsult.net

End of report
Smart Contract Audit

Request your smart contract audit / KYC

t.me/coinsult_tg