Coinsult

Request your audit at coinsult.net

Advanced Manual
Smart Contract Audit

July 12, 2022

Audit requested by

Smart Lottery

0xfEA099BB53daF7Bb7248042e53983d8715816Aa4

Smart Lottery / Security Audit

Table of Contents

1. Audit Summary

1.1 Audit scope

1.2 Tokenomics

1.3 Source Code

2. Disclaimer

3. Global Overview

3.1 Informational issues

3.2 Low-risk issues

3.3 Medium-risk issues

3.4 High-risk issues

4. Vulnerabilities Findings

5. Contract Privileges

5.1 Maximum Fee Limit Check

5.2 Contract Pausability Check

5.3 Max Transaction Amount Check

5.4 Exclude From Fees Check

5.5 Ability to Mint Check

5.6 Ability to Blacklist Check

5.7 Owner Privileges Check

6. Notes

6.1 Notes by Coinsult

6.2 Notes by Smart Lottery

7. Contract Snapshot

8. Website Review

9. Certificate of Proof

Smart Lottery / Security Audit

Audit Summary

Audit Scope

Project Name

Smart Lottery

Blockchain

Binance Smart Chain

Smart Contract Language

Solidity

Contract Address

0xfEA099BB53daF7Bb7248042e53983d8715816Aa4

Audit Method

Static Analysis, Manual Review

Date of Audit

12 July 2022

This audit report has been prepared by Coinsult’s experts at the request of the client. In this audit, the results of the static analysis and the manual code review will be presented. The purpose of the audit is to see if the functions work as intended, and to identify potential security issues within the smart contract.

The information in this report should be used to understand the risks associated with the smart contract. This report can be used as a guide for the development team on how the contract could possibly be improved by remediating the issues that were identified.

Smart Lottery / Security Audit

Tokenomics

Rank Address Quantity (Token) Percentage
1 0x09c0e1fac50d6ec7d2df142257213d881bf2fb2b 100,000,000 100.0000%

Source Code

Coinsult was comissioned by Smart Lottery to perform an audit based on the following code:
https://bscscan.com/address/0xfEA099BB53daF7Bb7248042e53983d8715816Aa4#code

Warning: Audit partner notified us that this project is likely to be related to Luck2Earn, which resulted in a scam. Please DYOR when investing in this project.

❌ KYC failed.

Smart Lottery / Security Audit

Disclaimer

This audit report has been prepared by Coinsult’s experts at the request of the client. In this audit, the results of the static analysis and the manual code review will be presented. The purpose of the audit is to see if the functions work as intended, and to identify potential security issues within the smart contract.

The information in this report should be used to understand the risks associated with the smart contract. This report can be used as a guide for the development team on how the contract could possibly be improved by remediating the issues that were identified.

Coinsult is not responsible if a project turns out to be a scam, rug-pull or honeypot. We only provide a detailed analysis for your own research.

Coinsult is not responsible for any financial losses. Nothing in this contract audit is financial advice, please do your own research.

The information provided in this audit is for informational purposes only and should not be considered investment advice. Coinsult does not endorse, recommend, support or suggest to invest in any project. 

Coinsult can not be held responsible for when a project turns out to be a rug-pull, honeypot or scam.

Smart Lottery / Security Audit

Global Overview

Manual Code Review

In this audit report we will highlight the following issues:

Vulnerability Level

Total

Pending

Acknowledged

Resolved

0

0

0

0

4

0

0

0

0

0

0

0

0

0

0

0

Privilege Overview

Coinsult checked the following privileges:

Contract Privilege

Description

Owner can mint?

Owner can blacklist?

Owner can set fees > 25%?

Owner can exclude from fees?

Owner can pause trading?

Owner can set Max TX amount?

More owner priviliges are listed later in the report.

Smart Lottery / Security Audit

Contract contains Reentrancy vulnerabilities

Additional information: This combination increases risk of malicious intent. While it may be justified by some complex mechanics (e.g. rebase, reflections, buyback). 

More information: Slither

				
					External calls:
- swapAndLiquify(contractTokenBalance) (smart.sol#267)
- idexV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (smart.sol#349-356)
- idexV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (smart.sol#333-339)
External calls sending eth:
- swapAndLiquify(contractTokenBalance) (smart.sol#267)
- recipient.transfer(amount) (smart.sol#232)
- idexV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (smart.sol#349-356)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (smart.sol#270)
- _balances[recipient] = _balances[recipient].add(finalAmount) (smart.sol#275)
- finalAmount = takeFee(sender,recipient,amount) (smart.sol#272-273)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (smart.sol#371)
				
			

Recommendation

Apply the check-effects-interactions pattern.

Exploit scenario

				
					    function withdrawBalance(){
        // send userBalance[msg.sender] Ether to msg.sender
        // if mgs.sender is a contract, it will call its fallback function
        if( ! (msg.sender.call.value(userBalance[msg.sender])() ) ){
            throw;
        }
        userBalance[msg.sender] = 0;
    }
				
			
Bob uses the re-entrancy bug to call withdrawBalance two times, and withdraw more than its initial deposit to the contract.

Smart Lottery / Security Audit

Too many digits

Literals with many digits are difficult to read and review.

				
					    uint256 private _totalSupply =  100000000 * 10**_decimals;      
				
			

Recommendation

Exploit scenario

				
					contract MyContract{
    uint 1_ether = 10000000000000000000; 
}
				
			

While 1_ether looks like 1 ether, it is 10 ether. As a result, it’s likely to be used incorrectly.

Smart Lottery / Security Audit

No zero address validation for some functions

Detect missing zero address validation.

				
					    function setMarketingWalletAddress(address newAddress) external onlyOwner() {
        marketingWalletAddress = payable(newAddress);
    }

    function setNftWalletAddress(address newAddress) external onlyOwner() {
        nftWalletAddress = payable(newAddress);
    }

    function setAppWalletAddress(address newAddress) external onlyOwner() {
        appWalletAddress = payable(newAddress);
    }
				
			

Recommendation

Check that the new address is not zero.

Exploit scenario

				
					contract C {

  modifier onlyAdmin {
    if (msg.sender != owner) throw;
    _;
  }

  function updateOwner(address newOwner) onlyAdmin external {
    owner = newOwner;
  }
}
				
			

Bob calls updateOwner without specifying the newOwner, soBob loses ownership of the contract.

Smart Lottery / Security Audit

Missing events arithmetic

Detect missing events for critical arithmetic parameters.

				
					    function setBuyTaxes(uint256 newLiquidityTax, uint256 newMarketingTax, uint256 newNftTax, uint256 newAppTax) external onlyOwner() {
        require(newLiquidityTax.add(newMarketingTax).add(newNftTax).add(newAppTax) <= 18, "Tax exceeds the 18%.");
        _buyLiquidityFee = newLiquidityTax;
        _buyMarketingFee = newMarketingTax;
        _buyNftFee = newNftTax;
        _buyAppFee = newAppTax;

        _totalTaxIfBuying = _buyLiquidityFee.add(_buyMarketingFee).add(_buyNftFee).add(_buyAppFee);
    }

    function setSelTaxes(uint256 newLiquidityTax, uint256 newMarketingTax, uint256 newNftTax, uint256 newAppTax) external onlyOwner() {
        require(newLiquidityTax.add(newMarketingTax).add(newNftTax).add(newAppTax) <= 18, "Tax exceeds the 18%.");
        _sellLiquidityFee = newLiquidityTax;
        _sellMarketingFee = newMarketingTax;
        _sellNftFee = newNftTax;
        _sellAppFee=newAppTax;

        _totalTaxIfSelling = _sellLiquidityFee.add(_sellMarketingFee).add(_sellNftFee).add(_sellAppFee);
    }
				
			

Recommendation

Emit an event for critical parameter changes.

Exploit scenario

				
					contract C {

  modifier onlyAdmin {
    if (msg.sender != owner) throw;
    _;
  }

  function updateOwner(address newOwner) onlyAdmin external {
    owner = newOwner;
  }
}
				
			

updateOwner() has no event, so it is difficult to track off-chain changes in the buy price.

Smart Lottery / Security Audit

Contract Privileges

Maximum Fee Limit Check

Coinsult tests if the owner of the smart contract can set the transfer, buy or sell fee to 25% or more. It is bad practice to set the fees to 25% or more, because owners can prevent healthy trading or even stop trading when the fees are set too high. 

Type of fee

Description

Transfer fee

Buy fee

Sell fee

Type of fee

Description

Max transfer fee

Max buy fee

Max sell fee

Smart Lottery / Security Audit

Contract Pausability Check

Coinsult tests if the owner of the smart contract has the ability to pause the contract. If this is the case, users can no longer interact with the smart contract; users can no longer trade the token.

Privilege Check

Description

Can owner pause the contract?

Smart Lottery / Security Audit

Max Transaction Amount Check

Coinsult tests if the owner of the smart contract can set the maximum amount of a transaction. If the transaction exceeds this limit, the transaction will revert. Owners could prevent normal transactions to take place if they abuse this function.

Privilege Check

Description

Can owner set max tx amount?

Smart Lottery / Security Audit

Exclude From Fees Check

Coinsult tests if the owner of the smart contract can exclude addresses from paying tax fees. If the owner of the smart contract can exclude from fees, they could set high tax fees and exclude themselves from fees and benefit from 0% trading fees. However, some smart contracts require this function to exclude routers, dex, cex or other contracts / wallets from fees.

Privilege Check

Description

Can owner exclude from fees?

Smart Lottery / Security Audit

Ability To Mint Check

Coinsult tests if the owner of the smart contract can mint new tokens. If the contract contains a mint function, we refer to the token’s total supply as non-fixed, allowing the token owner to “mint” more tokens whenever they want.

A mint function in the smart contract allows minting tokens at a later stage. A method to disable minting can also be added to stop the minting process irreversibly.

Minting tokens is done by sending a transaction that creates new tokens inside of the token smart contract. With the help of the smart contract function, an unlimited number of tokens can be created without spending additional energy or money.

Privilege Check

Description

Can owner mint?

Smart Lottery / Security Audit

Ability To Blacklist Check

Coinsult tests if the owner of the smart contract can blacklist accounts from interacting with the smart contract. Blacklisting methods allow the contract owner to enter wallet addresses which are not allowed to interact with the smart contract. 

This method can be abused by token owners to prevent certain / all holders from trading the token. However, blacklists might be good for tokens that want to rule out certain addresses from interacting with a smart contract.

Privilege Check

Description

Can owner blacklist?

Smart Lottery / Security Audit

Other Owner Privileges Check

Coinsult lists all important contract methods which the owner can interact with.

✅ No other important owner privileges to mention.

Smart Lottery / Security Audit

Notes

Notes by Smart Lottery

No notes provided by the team.

Notes by Coinsult

Warning: Audit partner notified us that this project is likely to be related to Luck2Earn, which resulted in a scam. Please DYOR when investing in this project.

❌ KYC failed.

Smart Lottery / Security Audit

Contract Snapshot

This is how the constructor of the contract looked at the time of auditing the smart contract.

				
					contract SmartLottery is Context, IERC20, Ownable {
    
    using SafeMath for uint256;
    using Address for address;
    
    string private _name = "SmartLottery";
    string private _symbol = "SMT";
    uint8 private _decimals = 18;


    address payable public marketingWalletAddress = payable(0x79d67df82bE1469D9B6De9CaaC38217B64e8a319);
    address payable public nftWalletAddress = payable(0x7aFCa110982714A8b58d91C25E9f268482B0Fa58);
    address payable public appWalletAddress = payable(0xB6FA8Ae61133908f02E1E179C01cf6C838810233);
    address public immutable deadAddress = 0x000000000000000000000000000000000000dEaD;
    
    mapping (address => uint256) _balances;
    mapping (address => mapping (address => uint256)) private _allowances;
    
    mapping (address => bool) public isExcludedFromFee;
    mapping (address => bool) public isMarketPair;

    uint256 public _buyLiquidityFee = 0;
    uint256 public _buyMarketingFee = 2;
    uint256 public _buyNftFee = 0;
    uint256 public _buyAppFee = 1;
    
    uint256 public _sellLiquidityFee = 0;
    uint256 public _sellMarketingFee = 3;
    uint256 public _sellNftFee = 0;
    uint256 public _sellAppFee = 1;

    uint256 public _liquidityShare = 10;
    uint256 public _marketingShare = 45;
    uint256 public _nftShare = 15;
    uint256 public _appShare = 30;

    uint256 public _totalTaxIfBuying = 2;
    uint256 public _totalTaxIfSelling = 4;
    uint256 public _totalDistributionShares = 100;
				
			

Smart Lottery / Security Audit

Website Review

Coinsult checks the website completely manually and looks for visual, technical and textual errors. We also look at the security, speed and accessibility of the website. In short, a complete check to see if the website meets the current standard of the web development industry. 

Type of check

Description

Mobile friendly?

Contains jQuery errors?

Is SSL secured?

Contains spelling errors?

Smart Lottery / Security Audit

Certificate of Proof

Smart Lottery

Audited by Coinsult.net

Date: 12 July 2022

Coinsult

coinsult.net

End of report
Smart Contract Audit

Request your smart contract audit / KYC

t.me/coinsult_tg