Coinsult

Request your audit at coinsult.net

Advanced Manual
Smart Contract Audit

May 24, 2022

Audit requested by

Treasure Hunt Token (TestNet)

0x961Dfae80dFee9817f03DBd17a82d9f6E49C3c02 (TESTNET)

Treasure Hunt Token (TestNet) / Security Audit

Table of Contents

1. Audit Summary

1.1 Audit scope

1.2 Tokenomics

1.3 Source Code

2. Disclaimer

3. Global Overview

3.1 Informational issues

3.2 Low-risk issues

3.3 Medium-risk issues

3.4 High-risk issues

4. Vulnerabilities Findings

5. Contract Privileges

5.1 Maximum Fee Limit Check

5.2 Contract Pausability Check

5.3 Max Transaction Amount Check

5.4 Exclude From Fees Check

5.5 Ability to Mint Check

5.6 Ability to Blacklist Check

5.7 Owner Privileges Check

6. Notes

6.1 Notes by Coinsult

6.2 Notes by Treasure Hunt Token (TestNet)

7. Contract Snapshot

8. Website Review

9. Certificate of Proof

Treasure Hunt Token (TestNet) / Security Audit

Audit Summary

Audit Scope

Project Name

Treasure Hunt Token (TestNet)

Blockchain

Binance Smart Chain

Smart Contract Language

Solidity

Contract Address

0x961Dfae80dFee9817f03DBd17a82d9f6E49C3c02 (TESTNET)

Audit Method

Static Analysis, Manual Review

Date of Audit

24 May 2022

This audit report has been prepared by Coinsult’s experts at the request of the client. In this audit, the results of the static analysis and the manual code review will be presented. The purpose of the audit is to see if the functions work as intended, and to identify potential security issues within the smart contract.

The information in this report should be used to understand the risks associated with the smart contract. This report can be used as a guide for the development team on how the contract could possibly be improved by remediating the issues that were identified.

Treasure Hunt Token (TestNet) / Security Audit

Tokenomics

Testnet.

Source Code

Coinsult was comissioned by Treasure Hunt Token (TestNet) to perform an audit based on the following code:
https://ropsten.etherscan.io/address/0x961Dfae80dFee9817f03DBd17a82d9f6E49C3c02#code

Audit based on testnet contract

Treasure Hunt Token (TestNet) / Security Audit

Disclaimer

This audit report has been prepared by Coinsult’s experts at the request of the client. In this audit, the results of the static analysis and the manual code review will be presented. The purpose of the audit is to see if the functions work as intended, and to identify potential security issues within the smart contract.

The information in this report should be used to understand the risks associated with the smart contract. This report can be used as a guide for the development team on how the contract could possibly be improved by remediating the issues that were identified.

Coinsult is not responsible if a project turns out to be a scam, rug-pull or honeypot. We only provide a detailed analysis for your own research.

Coinsult is not responsible for any financial losses. Nothing in this contract audit is financial advice, please do your own research.

The information provided in this audit is for informational purposes only and should not be considered investment advice. Coinsult does not endorse, recommend, support or suggest to invest in any project. 

Coinsult can not be held responsible for when a project turns out to be a rug-pull, honeypot or scam.

Treasure Hunt Token (TestNet) / Security Audit

Global Overview

Manual Code Review

In this audit report we will highlight the following issues:

Vulnerability Level

Total

Pending

Acknowledged

Resolved

0

0

0

0

5

0

0

0

0

0

0

0

0

0

0

0

Privilege Overview

Coinsult checked the following privileges:

Contract Privilege

Description

Owner can mint?

Owner can blacklist?

Owner can set fees > 25%?

Owner can exclude from fees?

Owner can pause trading?

Owner can set Max TX amount?

More owner priviliges are listed later in the report.

Treasure Hunt Token (TestNet) / Security Audit

Contract contains Reentrancy vulnerabilities

Additional information: This combination increases risk of malicious intent. While it may be justified by some complex mechanics (e.g. rebase, reflections, buyback). 

More information: Slither

				
					    function _tokenTransfer(address sender, address recipient, uint256 amount, bool isBuy, bool isSell) private {  
        _beforeTokenTransfer(sender, recipient, amount);

        unchecked {
            _balances[sender] = balanceOf(sender) - amount;
        }

        if (isSell) {
            _balances[recipient] += deductSellFees(amount, sender);
        } else if (isBuy) {
            _balances[recipient] += deductBuyFees(amount, sender);
        } else {
            _balances[recipient] += amount;

            emit Transfer(sender, recipient, amount);
        }

        _afterTokenTransfer(sender, recipient, amount);      
    }

    function deductBuyFees(uint256 amount, address sender) private returns(uint256) {
        uint256 totalFees = percent(amount, buyFeeRates.treasureNFee) 
                            + percent(amount, buyFeeRates.liquidityFee)
                            + percent(amount, buyFeeRates.treasureFee)
                            + percent(amount, buyFeeRates.marketingFee)
                            + percent(amount, buyFeeRates.operationFee);

        _balances[treasureFeeAddr] += percent(amount, buyFeeRates.treasureNFee);
        _balances[address(this)] += percent(amount, buyFeeRates.liquidityFee);
        _balances[address(this)] += percent(amount, buyFeeRates.treasureFee);
        _balances[address(this)] += percent(amount, buyFeeRates.marketingFee);
        _balances[address(this)] += percent(amount, buyFeeRates.operationFee);

        pendingToPay.liquidityFee += percent(amount, buyFeeRates.liquidityFee);
        pendingToPay.treasureFee += percent(amount, buyFeeRates.treasureFee);
        pendingToPay.marketingFee += percent(amount, buyFeeRates.marketingFee);
        pendingToPay.operationFee += percent(amount, buyFeeRates.operationFee);
        
        emit Transfer(sender, treasureFeeAddr, percent(amount, buyFeeRates.treasureNFee));
        emit Transfer(sender, address(this), percent(amount, buyFeeRates.liquidityFee));
        emit Transfer(sender, address(this), percent(amount, buyFeeRates.treasureFee));
        emit Transfer(sender, address(this), percent(amount, buyFeeRates.marketingFee));
        emit Transfer(sender, address(this), percent(amount, buyFeeRates.operationFee));

        return amount.sub(totalFees);
    }

				
			

Recommendation

Apply the check-effects-interactions pattern.

Exploit scenario

				
					    function withdrawBalance(){
        // send userBalance[msg.sender] Ether to msg.sender
        // if mgs.sender is a contract, it will call its fallback function
        if( ! (msg.sender.call.value(userBalance[msg.sender])() ) ){
            throw;
        }
        userBalance[msg.sender] = 0;
    }
				
			
Bob uses the re-entrancy bug to call withdrawBalance two times, and withdraw more than its initial deposit to the contract.

Treasure Hunt Token (TestNet) / Security Audit

Avoid relying on block.timestamp

block.timestamp can be manipulated by miners.

				
					        // add the liquidity
        uniswapV2Router.addLiquidityETH{value: ethAmount}(
            address(this),
            tokenAmount,
            0, // slippage is unavoidable
            0, // slippage is unavoidable
            liquidityWallet,
            block.timestamp
        );  
				
			

Recommendation

Do not use block.timestampnow or blockhash as a source of randomness

Exploit scenario

				
					contract Game {

    uint reward_determining_number;

    function guessing() external{
      reward_determining_number = uint256(block.blockhash(10000)) % 10;
    }
}
				
			

Eve is a miner. Eve calls guessing and re-orders the block containing the transaction. As a result, Eve wins the game.

Treasure Hunt Token (TestNet) / Security Audit

Too many digits

Literals with many digits are difficult to read and review.

				
					uint256 public swapTokensAtAmount = 100_000 * 10**18;
				
			

Recommendation

Exploit scenario

				
					contract MyContract{
    uint 1_ether = 10000000000000000000; 
}
				
			

While 1_ether looks like 1 ether, it is 10 ether. As a result, it’s likely to be used incorrectly.

Treasure Hunt Token (TestNet) / Security Audit

No zero address validation for some functions

Detect missing zero address validation.

				
					    function setAddresses(address _treasureFeeAddr, address _marketingFeeAddr, address _operationFeeAddr) external 
    onlyOwner {
            treasureFeeAddr = _treasureFeeAddr;
            marketingFeeAddr = _marketingFeeAddr;
            operationFeeAddr = _operationFeeAddr;
    }

				
			

Recommendation

Check that the new address is not zero.

Exploit scenario

				
					contract C {

  modifier onlyAdmin {
    if (msg.sender != owner) throw;
    _;
  }

  function updateOwner(address newOwner) onlyAdmin external {
    owner = newOwner;
  }
}
				
			

Bob calls updateOwner without specifying the newOwner, soBob loses ownership of the contract.

Treasure Hunt Token (TestNet) / Security Audit

Unchecked transfer

The return value of an external transfer/transferFrom call is not checked.

				
					        if(amount == 0) {
            super._transfer(from, to, 0);
            return;
        }
				
			

Recommendation

Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Exploit scenario

				
					contract Token {
    function transferFrom(address _from, address _to, uint256 _value) public returns (bool success);
}
contract MyBank{  
    mapping(address => uint) balances;
    Token token;
    function deposit(uint amount) public{
        token.transferFrom(msg.sender, address(this), amount);
        balances[msg.sender] += amount;
    }
}
				
			

Several tokens do not revert in case of failure and return false. If one of these tokens is used in MyBankdeposit will not revert if the transfer fails, and an attacker can call deposit for free..

Treasure Hunt Token (TestNet) / Security Audit

Missing events arithmetic

Detect missing events for critical arithmetic parameters.

				
					    function setFeeRates(feeRateStruct memory _buyFeeRates, feeRateStruct memory _sellFeeRates) external onlyOwner {
        uint256 buyFees = _buyFeeRates.treasureNFee
                .add(_buyFeeRates.liquidityFee)
                .add(_buyFeeRates.treasureFee)
                .add(_buyFeeRates.marketingFee)
                .add(_buyFeeRates.operationFee);

        uint256 sellFees = _sellFeeRates.treasureNFee
                .add(_sellFeeRates.liquidityFee)
                .add(_sellFeeRates.treasureFee)
                .add(_sellFeeRates.marketingFee)
                .add(_sellFeeRates.operationFee);
        
        require(buyFees <= 1200, "buy fees above limt");
        require(sellFees <= 1200, "sell fees above limt");
        
        buyFeeRates = _buyFeeRates;
        sellFeeRates = _sellFeeRates;
    }
				
			

Recommendation

Emit an event for critical parameter changes.

Exploit scenario

				
					contract C {

  modifier onlyAdmin {
    if (msg.sender != owner) throw;
    _;
  }

  function updateOwner(address newOwner) onlyAdmin external {
    owner = newOwner;
  }
}
				
			

updateOwner() has no event, so it is difficult to track off-chain changes in the buy price.

Treasure Hunt Token (TestNet) / Security Audit

Boolean equality

Detects the comparison to boolean constants.

				
					require(blacklist[sender] == false && blacklist[recipient] == false, "You are blacklisted");
				
			

Recommendation

Remove the equality to the boolean constant.

Exploit scenario

				
					contract A {
	function f(bool x) public {
		// ...
        if (x == true) { // bad!
           // ...
        }
		// ...
	}
}
				
			

Boolean constants can be used directly and do not need to be compare to true or false.

Treasure Hunt Token (TestNet) / Security Audit

Contract Privileges

Maximum Fee Limit Check

Coinsult tests if the owner of the smart contract can set the transfer, buy or sell fee to 25% or more. It is bad practice to set the fees to 25% or more, because owners can prevent healthy trading or even stop trading when the fees are set too high. 

Type of fee

Description

Transfer fee

Buy fee

Sell fee

Type of fee

Description

Max transfer fee

Max buy fee

Max sell fee

Treasure Hunt Token (TestNet) / Security Audit

Contract Pausability Check

Coinsult tests if the owner of the smart contract has the ability to pause the contract. If this is the case, users can no longer interact with the smart contract; users can no longer trade the token.

Privilege Check

Description

Can owner pause the contract?

Treasure Hunt Token (TestNet) / Security Audit

Max Transaction Amount Check

Coinsult tests if the owner of the smart contract can set the maximum amount of a transaction. If the transaction exceeds this limit, the transaction will revert. Owners could prevent normal transactions to take place if they abuse this function.

Privilege Check

Description

Can owner set max tx amount?

Treasure Hunt Token (TestNet) / Security Audit

Exclude From Fees Check

Coinsult tests if the owner of the smart contract can exclude addresses from paying tax fees. If the owner of the smart contract can exclude from fees, they could set high tax fees and exclude themselves from fees and benefit from 0% trading fees. However, some smart contracts require this function to exclude routers, dex, cex or other contracts / wallets from fees.

Privilege Check

Description

Can owner exclude from fees?

Treasure Hunt Token (TestNet) / Security Audit

Ability To Mint Check

Coinsult tests if the owner of the smart contract can mint new tokens. If the contract contains a mint function, we refer to the token’s total supply as non-fixed, allowing the token owner to “mint” more tokens whenever they want.

A mint function in the smart contract allows minting tokens at a later stage. A method to disable minting can also be added to stop the minting process irreversibly.

Minting tokens is done by sending a transaction that creates new tokens inside of the token smart contract. With the help of the smart contract function, an unlimited number of tokens can be created without spending additional energy or money.

Privilege Check

Description

Can owner mint?

Treasure Hunt Token (TestNet) / Security Audit

Ability To Blacklist Check

Coinsult tests if the owner of the smart contract can blacklist accounts from interacting with the smart contract. Blacklisting methods allow the contract owner to enter wallet addresses which are not allowed to interact with the smart contract. 

This method can be abused by token owners to prevent certain / all holders from trading the token. However, blacklists might be good for tokens that want to rule out certain addresses from interacting with a smart contract.

Privilege Check

Description

Can owner blacklist?

Treasure Hunt Token (TestNet) / Security Audit

Other Owner Privileges Check

Coinsult lists all important contract methods which the owner can interact with.

⚠ Owner can withdraw funds sent to the contract address

⚠ Owner can change the router address

Treasure Hunt Token (TestNet) / Security Audit

Notes

Notes by Treasure Hunt Token (TestNet)

No notes provided by the team.

Notes by Coinsult

✅ No notes provided by Coinsult

Treasure Hunt Token (TestNet) / Security Audit

Contract Snapshot

This is how the constructor of the contract looked at the time of auditing the smart contract.

				
					contract TreasureHuntToken is ERC20, Ownable {
    using SafeMath for uint256;

    // Link contract to BUSD for BUSD swapping
    address public immutable BUSDToken = address(0xe9e7CEA3DedcA5984780Bafc599bD69ADd087D56);
    
    // Allow transactions via pancakeswap upon deployment and liquidity
    IUniswapV2Router02 public uniswapV2Router;
    address public uniswapV2Pair;
    bool private swapping;
    bool public tradingIsEnabled = true;

    
    // Create the wallets
    address public treasureWallet;
    address public liquidityWallet;
    address public marketingWallet;
    address public operationsWallet;   
    
    // Set max sell to avoid honeypot investors
    uint256 public maxSellTransactionAmount = 100000 * (10**18);
    // Set amount to trigger token swapping for liquidity
    uint256 public swapTokensAtAmount = 10000 * (10**18);   
    
    // Define the fees
    uint256 public TreasureFee;
    uint256 public LiquidityFee;
    uint256 public BNBTreasureFee;
    uint256 public marketingFee;
    uint256 public operationsFee;
    uint256 public maxWalletAmount;
    uint256 public tTotal;
    uint256 public totalFees;
    
    // Exlcude from fees and max transaction amount
    mapping (address => bool) private _isExcludedFromFees;
    
    // Addresses that can make transfers before presale is over
    mapping (address => bool) public canTransferBeforeTradingIsEnabled;
    
    // Bots Blacklist
    mapping(address => bool) private bots;
    
    // Store addresses that a automatic market maker pairs. Any transfer *to* these addresses could be subject to a maximum transfer amount
    mapping (address => bool) public automatedMarketMakerPairs;
    
    // Events to be emitted during functions within the contract
    event UpdateUniswapV2Router(address indexed newAddress, address indexed oldAddress);
    event ExcludeFromFees(address indexed account, bool isExcluded);
    event ExcludeMultipleAccountsFromFees(address[] accounts, bool isExcluded);
    event SetAutomatedMarketMakerPair(address indexed pair, bool indexed value);
    event LiquidityWalletUpdated(address indexed newLiquidityWallet, address indexed oldLiquidityWallet);
    event MarketingWalletUpdated(address indexed newMarketingWallet, address indexed oldMarketingWallet);
    event TreasureWalletUpdated(address indexed newTreasureWallet, address indexed oldTreasureWallet);
    event OperationsWalletUpdated(address indexed newOperationsWallet, address indexed oldOperationsWallet);
    event SwapAndLiquify(
				
			

Treasure Hunt Token (TestNet) / Security Audit

Website Review

Coinsult checks the website completely manually and looks for visual, technical and textual errors. We also look at the security, speed and accessibility of the website. In short, a complete check to see if the website meets the current standard of the web development industry. 

Type of check

Description

Mobile friendly?

Contains jQuery errors?

Is SSL secured?

Contains spelling errors?

Treasure Hunt Token (TestNet) / Security Audit

Certificate of Proof

Treasure Hunt Token (TestNet)

Audited by Coinsult.net

Date: 24 May 2022

Coinsult

coinsult.net

End of report
Smart Contract Audit

Request your smart contract audit / KYC

t.me/coinsult_tg